----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/#review147783 -----------------------------------------------------------
src/tests/containerizer/isolator_tests.cpp (lines 195 - 210) <https://reviews.apache.org/r/50733/#comment215022> I'd suggest we create a new file: ``` src/tests/containerizer/cpu_isolator_tests.cpp ``` src/tests/containerizer/isolator_tests.cpp (line 218) <https://reviews.apache.org/r/50733/#comment215023> Instead of using TYPED_TEST, let's use TEST_P and let the flags.isolation be the param. We should launch a master/agent, and launch the command using command executor. Let's take this opportunity to cleanup those tests. src/tests/containerizer/isolator_tests.cpp (lines 528 - 532) <https://reviews.apache.org/r/50733/#comment215024> Let's move this to cgroups_isolator_tests.cpp src/tests/containerizer/isolator_tests.cpp (line 540) <https://reviews.apache.org/r/50733/#comment215025> Ditto. Let's use master/agent/command to launch /bin/sleep src/tests/containerizer/isolator_tests.cpp (lines 607 - 613) <https://reviews.apache.org/r/50733/#comment215026> Ditto. - Jie Yu On Sept. 5, 2016, 4:03 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50733/ > ----------------------------------------------------------- > > (Updated Sept. 5, 2016, 4:03 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5973 > https://issues.apache.org/jira/browse/MESOS-5973 > > > Repository: mesos > > > Description > ------- > > Removed CgroupsCpushareIsolatorProcess. > > > Diffs > ----- > > src/CMakeLists.txt b14132abf49a73defd3e4774330b5227726b9207 > src/Makefile.am e296e31be6706ac9e9e052b7cc81bad0572d6028 > src/docker/docker.cpp 16abf64f98cc833ea4bee28bc08951eb2ff6d995 > src/slave/containerizer/mesos/containerizer.cpp > 89b7e8db38916d69d9b2d4fe305d4397b0859a10 > src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp > 74982a610b6c0a74734165a0c6aa8c9f72f54deb > src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp > 221e814a448c4b5df9dab98de597451a24e2b89c > src/tests/containerizer/isolator_tests.cpp > f8056ca08029feed5f164d4f94e24d521183bdfc > > Diff: https://reviews.apache.org/r/50733/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
