> On Sept. 5, 2016, 10:48 p.m., Jie Yu wrote: > > src/tests/containerizer/isolator_tests.cpp, lines 197-212 > > <https://reviews.apache.org/r/50733/diff/13/?file=1491003#file1491003line197> > > > > I'd suggest we create a new file: > > ``` > > src/tests/containerizer/cpu_isolator_tests.cpp > > ```
I put the refactor in this patch: https://reviews.apache.org/r/51787 - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50733/#review147783 ----------------------------------------------------------- On Sept. 11, 2016, 3:59 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50733/ > ----------------------------------------------------------- > > (Updated Sept. 11, 2016, 3:59 p.m.) > > > Review request for mesos, Gilbert Song, Jie Yu, Qian Zhang, and Zhengju Sha. > > > Bugs: MESOS-5973 > https://issues.apache.org/jira/browse/MESOS-5973 > > > Repository: mesos > > > Description > ------- > > Removed CgroupsCpushareIsolatorProcess. > > > Diffs > ----- > > src/CMakeLists.txt 01ef494f7120156de3b826d7def76fb30bcc61b5 > src/Makefile.am fa71381741083d3148ddaec715a862d65fc5c990 > src/docker/docker.cpp 16abf64f98cc833ea4bee28bc08951eb2ff6d995 > src/slave/containerizer/mesos/containerizer.cpp > 1a120f191e4ff0e2b31dd0a9a6bced784a56612c > src/slave/containerizer/mesos/isolators/cgroups/cpushare.hpp > 74982a610b6c0a74734165a0c6aa8c9f72f54deb > src/slave/containerizer/mesos/isolators/cgroups/cpushare.cpp > 221e814a448c4b5df9dab98de597451a24e2b89c > src/tests/containerizer/isolator_tests.cpp > f8056ca08029feed5f164d4f94e24d521183bdfc > > Diff: https://reviews.apache.org/r/50733/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
