> On 九月 5, 2016, 11:23 p.m., Jiang Yan Xu wrote: > > src/tests/hierarchical_allocator_tests.cpp, lines 2718-2720 > > <https://reviews.apache.org/r/51028/diff/2/?file=1476333#file1476333line2718> > > > > How about: > > > > ``` > > // Wait for the allocation triggered from `addSlave()` to complete. > > // Otherwise `addFramework()` below may not trigger a new allocation > > // because the allocator batches them. > > ``` > > > > I reordered words in the first sentence and clarified `close > > succession` in the second.
What about highlight the comment with `the addSlave may not finished thus the allocation will not be triggered`? ``` // Wait for the allocation triggered from `addSlave()` to complete. // Otherwise `addFramework()` below may not trigger a new allocation // because the `addSlave` may not finished yet. ``` - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51028/#review147697 ----------------------------------------------------------- On 八月 23, 2016, 8:47 a.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51028/ > ----------------------------------------------------------- > > (Updated 八月 23, 2016, 8:47 a.m.) > > > Review request for mesos and Jiang Yan Xu. > > > Bugs: MESOS-3157 > https://issues.apache.org/jira/browse/MESOS-3157 > > > Repository: mesos > > > Description > ------- > > - Per MESOS-3157, if cluster events with the possibility > of triggering an allocation occur rapidly and test > assertions depend on gleaning information from assumed > order, it is likely they will fail due to lack of parity > between event and actual allocation. Settle the clock > between these events in tests sensitive to this to ensure > expected allocations occur. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > cbed333f497016fe2811f755028796012b41db77 > > Diff: https://reviews.apache.org/r/51028/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jacob Janco > >
