----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51736/#review148392 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp (lines 127 - 128) <https://reviews.apache.org/r/51736/#comment215843> Can you add some comments about what these two are? - Jie Yu On Sept. 9, 2016, 7:06 p.m., Avinash sridharan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51736/ > ----------------------------------------------------------- > > (Updated Sept. 9, 2016, 7:06 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-6023 > https://issues.apache.org/jira/browse/MESOS-6023 > > > Repository: mesos > > > Description > ------- > > Added fields `chain` and `excludeDevices` to `PortMapper`. > > > Diffs > ----- > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.hpp > 85547533b0b13011615b512ec8c71b7545f33324 > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > 0ecf64f2de5fc27f208e9dd0e3608b9a6750e9a6 > > Diff: https://reviews.apache.org/r/51736/diff/ > > > Testing > ------- > > make > > > Thanks, > > Avinash sridharan > >
