----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51779/#review148415 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/slave/containerizer.proto (line 73) <https://reviews.apache.org/r/51779/#comment215873> checkpointed_container_states. - Jie Yu On Sept. 10, 2016, 10:13 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51779/ > ----------------------------------------------------------- > > (Updated Sept. 10, 2016, 10:13 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, Jie Yu, Joseph > Wu, and Kevin Klues. > > > Repository: mesos > > > Description > ------- > > This protobuf message is used for the new isolator::recover interface. > We decided to make this change for the following reasons: > > 1. For nested containers support, the old isolator::recover parameters > are not sufficient to include necessary information for recovering > nested containers. E.g., a top level alive executor container may > contain nested containers that are unknown. Currently, the > checkpointed ContainerState list and orphans hashset are not enough > for isolators to figure out those unknown nested containers under > an alive top level container. So unfortunately, to support nested > containers, we have to change the isolator::recover interface. We > could have added an extra parameter 'knownContainers' to isolator > recover, which simply includes a full list of known containers. > This make it backward compatible, but those three parameters > contain duplicate information which is confusing for developers. > As a result, after a second thought, we realize this may be an > appropriate chance to change the isolator recover interface and > wrap everything into a protobuf. > > 2. Another benefit from this change is that it not only eliminates > the confusing parameters, but also make future work on isolator > recover much more easier, which would no longer break previous > users. It would spare a lot of burdens in isolator::recover > interface changes in the future. > > In this new protobuf message, we keep the two parameters in old > isolator::recover as the first two proto field, which makes it > straightforward for isolator modules to update. The third field > represents a full list of known containers, which will be used > for isolator::recover nested aware support. > > > Diffs > ----- > > include/mesos/slave/containerizer.proto > 16dd3a19145b9764273cdb9a8899e353c98730e5 > > Diff: https://reviews.apache.org/r/51779/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >
