> On Sept. 7, 2016, 7:21 p.m., Joris Van Remoortere wrote: > > src/slave/slave.cpp, lines 559-561 > > <https://reviews.apache.org/r/42861/diff/8/?file=1322438#file1322438line559> > > > > We should improve the error information here. Why can't we identify > > which original paths that were provided are overlapping? > > If we need to improve a library function we can add a TODO here and > > follow up with a patch.
Hi, @jvanremoortere, do you mean we should check `path::overlapping(source.mount().root())` without call `realpath`? - haosdent ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review148062 ----------------------------------------------------------- On Sept. 12, 2016, 5:29 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42861/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 5:29 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and > Neil Conway. > > > Bugs: MESOS-4521 > https://issues.apache.org/jira/browse/MESOS-4521 > > > Repository: mesos > > > Description > ------- > > Ensured two Mount Disk resources do not have the same root path. > > > Diffs > ----- > > src/slave/slave.cpp 2da5a2986c427250664b2bf3456039f86e5c6079 > > Diff: https://reviews.apache.org/r/42861/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
