> On Sept. 6, 2016, 10:38 p.m., Greg Mann wrote: > > Thanks Haosdent! Looks good. Could you also add a test for this? > > haosdent huang wrote: > Hi, @greggomann Thanks a lot for your reviews and helps! For test cases, > I think we have covered it in https://reviews.apache.org/r/42860/. So I think > not need to add it here.
We could also add an integration test which actually spins up an agent and checks that it will exit if it's given mount volumes with overlapping paths. However, in this case the unit tests may be good enough. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review147938 ----------------------------------------------------------- On Sept. 12, 2016, 5:29 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42861/ > ----------------------------------------------------------- > > (Updated Sept. 12, 2016, 5:29 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and > Neil Conway. > > > Bugs: MESOS-4521 > https://issues.apache.org/jira/browse/MESOS-4521 > > > Repository: mesos > > > Description > ------- > > Ensured two Mount Disk resources do not have the same root path. > > > Diffs > ----- > > src/slave/slave.cpp 2da5a2986c427250664b2bf3456039f86e5c6079 > > Diff: https://reviews.apache.org/r/42861/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
