----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42861/#review148062 -----------------------------------------------------------
As Greg said some tests would be great. Then we can ship this. src/slave/slave.cpp (lines 552 - 554) <https://reviews.apache.org/r/42861/#comment215449> We should improve the error information here. Why can't we identify which original paths that were provided are overlapping? If we need to improve a library function we can add a TODO here and follow up with a patch. - Joris Van Remoortere On April 1, 2016, 4:43 p.m., haosdent huang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/42861/ > ----------------------------------------------------------- > > (Updated April 1, 2016, 4:43 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, Joris Van Remoortere, and > Neil Conway. > > > Bugs: MESOS-4521 > https://issues.apache.org/jira/browse/MESOS-4521 > > > Repository: mesos > > > Description > ------- > > Ensure two Mount Disk resources do not have the same root path. > > > Diffs > ----- > > src/slave/slave.cpp fc77f594d16a9fb2ca001e089d74e2c0ffeb5baa > > Diff: https://reviews.apache.org/r/42861/diff/ > > > Testing > ------- > > > Thanks, > > haosdent huang > >
