-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50857/
-----------------------------------------------------------

(Updated Sept. 13, 2016, 6:13 p.m.)


Review request for mesos, Joseph Wu and Vinod Kone.


Changes
-------

Made use of the new metrics singleton.


Bugs: MESOS-3753
    https://issues.apache.org/jira/browse/MESOS-3753


Repository: mesos


Description
-------

This patch modifies the test `SchedulerTest.Teardown` to
be parametrized by both `ContentType` and SSL configuration,
and renames it to `SchedulerSSLTest.RunTaskAndTeardown`.
This allows the test to verify the scheduler's behavior with
SSL both enabled and disabled.


Diffs (updated)
-----

  src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 

Diff: https://reviews.apache.org/r/50857/diff/


Testing
-------

This test is currently flaky in the SSL-enabled configurations and I've seen it 
produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try:

`GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 
GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" 
bin/mesos-tests.sh`


Thanks,

Greg Mann

Reply via email to