----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50857/#review148799 -----------------------------------------------------------
Bad patch! Reviews applied: [50857, 50969, 50737, 51065, 50736, 40512, 40268, 40413, 40411, 40410, 50621, 51049, 40266, 46146, 46094, 45999, 45996, 45995, 45991] Failed command: ./support/apply-review.sh -n -r 51065 Error: 2016-09-13 23:07:26 URL:https://reviews.apache.org/r/51065/diff/raw/ [3635/3635] -> "51065.patch" [1] error: patch failed: 3rdparty/libprocess/include/process/ssl/gtest.hpp:363 error: 3rdparty/libprocess/include/process/ssl/gtest.hpp: patch does not apply Full log: https://builds.apache.org/job/mesos-reviewbot/15236/console - Mesos ReviewBot On Sept. 13, 2016, 6:13 p.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50857/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 6:13 p.m.) > > > Review request for mesos, Joseph Wu and Vinod Kone. > > > Bugs: MESOS-3753 > https://issues.apache.org/jira/browse/MESOS-3753 > > > Repository: mesos > > > Description > ------- > > This patch modifies the test `SchedulerTest.Teardown` to > be parametrized by both `ContentType` and SSL configuration, > and renames it to `SchedulerSSLTest.RunTaskAndTeardown`. > This allows the test to verify the scheduler's behavior with > SSL both enabled and disabled. > > > Diffs > ----- > > src/tests/scheduler_tests.cpp b0ea0bbcce9d847285fda40f778caaf721804457 > > Diff: https://reviews.apache.org/r/50857/diff/ > > > Testing > ------- > > This test is currently flaky in the SSL-enabled configurations and I've seen > it produce a segfault on Ubuntu 14.04 after 38 iterations. To reproduce, try: > > `GTEST_REPEAT=-1 GTEST_BREAK_ON_FAILURE=1 > GTEST_FILTER="ContentTypeAndSSLConfig/SchedulerSSLTest.RunTaskAndTeardown/2" > bin/mesos-tests.sh` > > > Thanks, > > Greg Mann > >