> On Sept. 13, 2016, 10:54 p.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 903-904 > > <https://reviews.apache.org/r/51864/diff/1/?file=1498009#file1498009line903> > > > > We already have such `LOG(INFO)` in provisioner::_provisioner(). > > > > Why do we add this here?
We may not see that line if container type is not `MESOS`. Regardless, I see value in explicitly printing at what stage the container is to facilitate triaging. On Sept. 13, 2016, 10:54 p.m., Alexander Rukletsov wrote: > > And each isolator should already have similar log info message as well. > > This would make it duplicate. I have a log where the container is sruck somewhere before any isolator printed something. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review148797 ----------------------------------------------------------- On Sept. 13, 2016, 10:47 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51864/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2016, 10:47 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/mesos/containerizer.cpp > dc18e4e3b0eca3f116f1e240217bbebf64a75e3a > > Diff: https://reviews.apache.org/r/51864/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Rukletsov > >
