> On Sept. 16, 2016, 8:09 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, lines 903-904 > > <https://reviews.apache.org/r/51864/diff/3/?file=1498873#file1498873line903> > > > > This is not correct. We dont always provision image for a container. > > > > It seems not necessary to me, because a log here will always be printed > > together with > > ``` > > LOG(INFO) << "Starting container " << containerId > > << " for executor '" << executorInfo.executor_id() > > << "' of framework " << executorInfo.framework_id(); > > ``` > > It is a redundant information. > > Gilbert Song wrote: > Maybe you want to put this log at L920.
Good idea. > On Sept. 16, 2016, 8:09 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/containerizer.cpp, line 967 > > <https://reviews.apache.org/r/51864/diff/3/?file=1498873#file1498873line967> > > > > We will attach container state in error/failure, but a log here should > > be more explicitly helpful for debugging. > > > > Just want to point out that, when people see (e.g., "5 isolators"), > > most users will be really curious about what exactly they are. > > > > I would suggest just dont include `isolators.size()` information. Too bad we can't query an isolator for its name! - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51864/#review149178 ----------------------------------------------------------- On Sept. 15, 2016, 1:35 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51864/ > ----------------------------------------------------------- > > (Updated Sept. 15, 2016, 1:35 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 > src/slave/containerizer/mesos/containerizer.cpp > dc18e4e3b0eca3f116f1e240217bbebf64a75e3a > > Diff: https://reviews.apache.org/r/51864/diff/ > > > Testing > ------- > > > Thanks, > > Alexander Rukletsov > >
