-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51864/#review149178
-----------------------------------------------------------




src/slave/containerizer/docker.cpp (lines 566 - 567)
<https://reviews.apache.org/r/51864/#comment216723>

    This sounds incorrect. No one really mount a container. Maybe you just want 
to say The container is in mounting state.



src/slave/containerizer/mesos/containerizer.cpp (lines 903 - 904)
<https://reviews.apache.org/r/51864/#comment216719>

    This is not correct. We dont always provision image for a container.
    
    It seems not necessary to me, because a log here will always be printed 
together with
    ```
      LOG(INFO) << "Starting container " << containerId
                << " for executor '" << executorInfo.executor_id()
                << "' of framework " << executorInfo.framework_id();
    ```
    It is a redundant information.



src/slave/containerizer/mesos/containerizer.cpp (line 967)
<https://reviews.apache.org/r/51864/#comment216721>

    We will attach container state in error/failure, but a log here should be 
more explicitly helpful for debugging.
    
    Just want to point out that, when people see (e.g., "5 isolators"), most 
users will be really curious about what exactly they are.
    
    I would suggest just dont include `isolators.size()` information.


- Gilbert Song


On Sept. 15, 2016, 6:35 a.m., Alexander Rukletsov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51864/
> -----------------------------------------------------------
> 
> (Updated Sept. 15, 2016, 6:35 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/docker.cpp a47e2ed88dcadb211c7f8c92eb4bada348d42780 
>   src/slave/containerizer/mesos/containerizer.cpp 
> dc18e4e3b0eca3f116f1e240217bbebf64a75e3a 
> 
> Diff: https://reviews.apache.org/r/51864/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alexander Rukletsov
> 
>

Reply via email to