----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/#review148944 -----------------------------------------------------------
Fix it, then Ship it! src/launcher/default_executor.cpp (lines 60 - 62) <https://reviews.apache.org/r/51885/#comment216468> for constructors we don't put the first argument on the next line IIRC. ``` DefaultExecutor(arg1, arg2); ``` src/launcher/default_executor.cpp (line 212) <https://reviews.apache.org/r/51885/#comment216469> why capture the task group as a member variable when you already have `tasks`? - Vinod Kone On Sept. 14, 2016, 9:34 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51885/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 9:34 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6077 > https://issues.apache.org/jira/browse/MESOS-6077 > > > Repository: mesos > > > Description > ------- > > This change adds a basic default executor implementation that > just sends a TASK_RUNNING update followed by a TASK_FINISHED > update upon the receipt of a LAUNCH_GROUP event from the executor. > This allows us to test the entire workflow for now. We can iterate > upon this to later send `LAUNCH_CONTAINER`/`DESTROY_CONTAINER` > to the agent to actually launch the tasks in a sub container. > > > Diffs > ----- > > src/Makefile.am 2dd7913a1477f3c3560be4e2c1450b93fb3afc78 > src/launcher/default_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51885/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
