> On Sept. 14, 2016, 6:04 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, line 212 > > <https://reviews.apache.org/r/51885/diff/1/?file=1498346#file1498346line212> > > > > why capture the task group as a member variable when you already have > > `tasks`?
`tasks` are a list of unacknowledged tasks i.e. as soon as I receive an acknowledgement for a status update pertaining to that task, we would remove it from `tasks`. Hence, we still need a member variable to store the task group. > On Sept. 14, 2016, 6:04 p.m., Vinod Kone wrote: > > src/launcher/default_executor.cpp, lines 60-62 > > <https://reviews.apache.org/r/51885/diff/1/?file=1498346#file1498346line60> > > > > for constructors we don't put the first argument on the next line IIRC. > > > > ``` > > DefaultExecutor(arg1, > > arg2); > > ``` hmm, that's not entirely true: https://github.com/apache/mesos/blob/master/src/master/master.cpp#L285 https://github.com/apache/mesos/blob/master/src/launcher/executor.cpp#L123 We should make it consistent throughout the code though. - Anand ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/#review148944 ----------------------------------------------------------- On Sept. 14, 2016, 9:34 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51885/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 9:34 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6077 > https://issues.apache.org/jira/browse/MESOS-6077 > > > Repository: mesos > > > Description > ------- > > This change adds a basic default executor implementation that > just sends a TASK_RUNNING update followed by a TASK_FINISHED > update upon the receipt of a LAUNCH_GROUP event from the executor. > This allows us to test the entire workflow for now. We can iterate > upon this to later send `LAUNCH_CONTAINER`/`DESTROY_CONTAINER` > to the agent to actually launch the tasks in a sub container. > > > Diffs > ----- > > src/Makefile.am 2dd7913a1477f3c3560be4e2c1450b93fb3afc78 > src/launcher/default_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51885/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
