> On 九月 14, 2016, 1:08 p.m., Guangya Liu wrote: > > How about rename this file as `default_pod_executor.cpp`? > > Vinod Kone wrote: > we are calling it "pod executor" because this executor will be able to > launch pod and non-pods in the future. command executor will be deprecated in > favor of this.
got it, thanks. > On 九月 14, 2016, 1:08 p.m., Guangya Liu wrote: > > src/launcher/default_executor.cpp, line 203 > > <https://reviews.apache.org/r/51885/diff/1/?file=1498346#file1498346line203> > > > > s/multiple task groups /multiple tasks in task group > > Vinod Kone wrote: > what anand reads correct to me. I think that here is not `multiple task groups` but `multiple tasks in one task group`? - Guangya ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51885/#review148886 ----------------------------------------------------------- On 九月 14, 2016, 9:34 a.m., Anand Mazumdar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51885/ > ----------------------------------------------------------- > > (Updated 九月 14, 2016, 9:34 a.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-6077 > https://issues.apache.org/jira/browse/MESOS-6077 > > > Repository: mesos > > > Description > ------- > > This change adds a basic default executor implementation that > just sends a TASK_RUNNING update followed by a TASK_FINISHED > update upon the receipt of a LAUNCH_GROUP event from the executor. > This allows us to test the entire workflow for now. We can iterate > upon this to later send `LAUNCH_CONTAINER`/`DESTROY_CONTAINER` > to the agent to actually launch the tasks in a sub container. > > > Diffs > ----- > > src/Makefile.am 2dd7913a1477f3c3560be4e2c1450b93fb3afc78 > src/launcher/default_executor.cpp PRE-CREATION > > Diff: https://reviews.apache.org/r/51885/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Anand Mazumdar > >
