-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45491/#review149196
-----------------------------------------------------------




3rdparty/libprocess/include/process/subprocess_base.hpp (line 79)
<https://reviews.apache.org/r/45491/#comment216874>

    Not yours, a space was missed here: `descriptor,in`



3rdparty/libprocess/include/process/subprocess_base.hpp (line 94)
<https://reviews.apache.org/r/45491/#comment216880>

    s/write/writes/



3rdparty/libprocess/include/process/subprocess_base.hpp (line 99)
<https://reviews.apache.org/r/45491/#comment216875>

    Ditto.



3rdparty/libprocess/include/process/subprocess_base.hpp (line 182)
<https://reviews.apache.org/r/45491/#comment216751>

    s/start/starts/



3rdparty/libprocess/src/subprocess.cpp (line 55)
<https://reviews.apache.org/r/45491/#comment216883>

    Need one more new line.



3rdparty/libprocess/src/subprocess.cpp (lines 65 - 66)
<https://reviews.apache.org/r/45491/#comment216882>

    This is the child hook for changing dir, so I think this comment is not 
correct.



3rdparty/libprocess/src/subprocess.cpp (line 81)
<https://reviews.apache.org/r/45491/#comment216884>

    s/setdid/setsid/


- Qian Zhang


On Sept. 12, 2016, 4:17 a.m., Joerg Schad wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45491/
> -----------------------------------------------------------
> 
> (Updated Sept. 12, 2016, 4:17 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Jie Yu.
> 
> 
> Bugs: MESOS-5070
>     https://issues.apache.org/jira/browse/MESOS-5070
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Previously the subprocess interface supported a several options for the
> child process such as setsid. In order to make the interface more
> flexible we refactored such options into a vector of ChildHooks.
> In order not to allow arbitrary code inside a ChildHook it has to be
> constructed via pre-defined factory methods.
> 
> 
> Diffs
> -----
> 
>   3rdparty/libprocess/include/process/posix/subprocess.hpp 
> 57f71d15e6fbb032c8b6c5d0c73a93751022e7e7 
>   3rdparty/libprocess/include/process/ssl/gtest.hpp 
> 2ad623a5ea3b3286983e895010af756f14f51b64 
>   3rdparty/libprocess/include/process/subprocess_base.hpp 
> acd23c99162f164c02a7781abeb95b3c220ead12 
>   3rdparty/libprocess/src/subprocess.cpp 
> 8ca61f77083ac4b77aa1aec22806e1be43dbfa6c 
>   3rdparty/libprocess/src/tests/subprocess_tests.cpp 
> 0ff3945d2c722ebc1529265427397c5dfba6854e 
> 
> Diff: https://reviews.apache.org/r/45491/diff/
> 
> 
> Testing
> -------
> 
> Tested entire chain see https://reviews.apache.org/r/45492.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Reply via email to