-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51621/#review149328
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51028, 51027, 51621]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 17, 2016, 1:29 a.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51621/
> -----------------------------------------------------------
> 
> (Updated Sept. 17, 2016, 1:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Jacob Janco, and Jiang Yan Xu.
> 
> 
> Bugs: MESOS-3078
>     https://issues.apache.org/jira/browse/MESOS-3078
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Please do not review for now as it is WIP.
> 
> Enable the `recoverResources` logic to call `ensureAllocation`,
> this can make sure the `allocationCandidates` can be updated
> as soon as possible and allocate the resources as soon as possible
> if there are no request in the message queue.
> 
> 
> Diffs
> -----
> 
>   src/master/allocator/mesos/hierarchical.cpp 
> 2d56bd011f2c87c67a02d0ae467a4a537d36867e 
>   src/tests/hierarchical_allocator_tests.cpp 
> 46553f6d501deb37862dd5ba48be1c114f6e6cb8 
>   src/tests/master_allocator_tests.cpp 
> b4ecd461d522503264ad2e25b2bf0cfc4a0ba12a 
>   src/tests/persistent_volume_tests.cpp 
> c38d8484fbd62b36bf124a96d17c8cae5e51e594 
>   src/tests/reservation_endpoints_tests.cpp 
> 28b497eccd5fadd03dc24e73e11e59ce36d78d32 
>   src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10 
>   src/tests/slave_tests.cpp 696e0f71190238133f29b6380bc58b994a556e69 
> 
> Diff: https://reviews.apache.org/r/51621/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> ```
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="*PersistentVolumeTest.BadACL*/*" --verbose --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="*PersistentVolumeTest.GoodACL*/*" --verbose --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="ReservationEndpointsTest.UnreserveAvailableAndOfferedResources"
>   --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="ReservationEndpointsTest.ReserveAvailableAndOfferedResources" 
>  --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="ReservationTest.ACLMultipleOperations" --verbose  
> --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterAllocatorTest/1.RebalancedForUpdatedWeights" 
> --gtest_repeat=30
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="HierarchicalAllocatorTest.UpdateWeight" --verbose 
> --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="MasterAllocatorTest/*.SlaveLost" --gtest_repeat=20
> GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="SlaveTest.ExecutorShutdownGracePeriod" --gtest_repeat=20
> ```
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to