----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51621/#review148904 -----------------------------------------------------------
Patch looks great! Reviews applied: [51028, 51027, 51621] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 14, 2016, 5:47 a.m., Guangya Liu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51621/ > ----------------------------------------------------------- > > (Updated Sept. 14, 2016, 5:47 a.m.) > > > Review request for mesos, Benjamin Mahler, Jacob Janco, and Jiang Yan Xu. > > > Bugs: MESOS-3078 > https://issues.apache.org/jira/browse/MESOS-3078 > > > Repository: mesos > > > Description > ------- > > Please do not review for now as it is WIP. > > Enable the `recoverResources` logic to call `ensureAllocation`, > this can make sure the `allocationCandidates` can be updated > as soon as possible and allocate the resources as soon as possible > if there are no request in the message queue. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 992031a6fbc89727725071841bd3ab827737d8bd > src/tests/hierarchical_allocator_tests.cpp > 7705de95a3916310baf4daca62aab1e6b1ca3cb3 > src/tests/master_allocator_tests.cpp > 7eed672be14f116d0aa5058da98a1db3a146dad9 > src/tests/persistent_volume_tests.cpp > d07ff1fd2f14c73c924a07ce3850bf0d9de2135a > src/tests/reservation_endpoints_tests.cpp > bee5ea6b3a3ee7fafb7312a6d89de79d62c57ec1 > src/tests/reservation_tests.cpp 000957826011bf28f7550a83db3e60a796162fb3 > src/tests/slave_tests.cpp 2f3fa5fae634b6250f3c00bbef3077493f79af95 > > Diff: https://reviews.apache.org/r/51621/diff/ > > > Testing > ------- > > make > make check > > ``` > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*PersistentVolumeTest.BadACL*/*" --verbose --gtest_repeat=20 > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="*PersistentVolumeTest.GoodACL*/*" --verbose --gtest_repeat=20 > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="ReservationEndpointsTest.UnreserveAvailableAndOfferedResources" > --gtest_repeat=20 > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="ReservationEndpointsTest.ReserveAvailableAndOfferedResources" > --gtest_repeat=20 > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="ReservationTest.ACLMultipleOperations" --verbose > --gtest_repeat=20 > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="MasterAllocatorTest/1.RebalancedForUpdatedWeights" > --gtest_repeat=30 > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="HierarchicalAllocatorTest.UpdateWeight" --verbose > --gtest_repeat=20 > GLOG_v=1 ./bin/mesos-tests.sh > --gtest_filter="MasterAllocatorTest/*.SlaveLost" --gtest_repeat=20 > ``` > > > Thanks, > > Guangya Liu > >
