-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51654/#review149491
-----------------------------------------------------------



Patch looks great!

Reviews applied: [51654]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; 
./support/docker_build.sh

- Mesos ReviewBot


On Sept. 19, 2016, 2:19 p.m., Benjamin Bannier wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51654/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 2:19 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> In this patch we add help displays for all current containerizer
> subcommands. We also trim existing display of the usage; here we use
> that `Flags::usage` already takes care of providing a header.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/network/cni/cni.cpp 
> 359479083894e887647a694a1a133dce44817073 
>   src/slave/containerizer/mesos/launch.cpp 
> fc51e04ec1572679e6a48ff4f0fa31ef2dfd6ec3 
>   src/slave/containerizer/mesos/mount.cpp 
> dbd7853a43ee1402f2f91d933a657010efdd76b0 
> 
> Diff: https://reviews.apache.org/r/51654/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> Confirmed by explicitly invoking
> 
>     $ mesos-containerizer launch --help
>     $ mesos-containerizer mount --help
>     $ mesos-containerizer network-cni-setup --help
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>

Reply via email to