----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51654/#review150964 -----------------------------------------------------------
Patch looks great! Reviews applied: [51654] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Sept. 29, 2016, 4:20 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51654/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2016, 4:20 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > In this patch we add help displays for all current containerizer > subcommands. We also trim existing display of the usage; here we use > that `Flags::usage` already takes care of providing a header. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/cni/cni.cpp > 1ee56cfa77a6b82f43882ab40d991c1937b5bd63 > src/slave/containerizer/mesos/launch.cpp > 7cc0c3f46fe1a5883b7ccd474595b8be412b355c > src/slave/containerizer/mesos/mount.cpp > dbd7853a43ee1402f2f91d933a657010efdd76b0 > > Diff: https://reviews.apache.org/r/51654/diff/ > > > Testing > ------- > > make check > > Confirmed by explicitly invoking > > $ mesos-containerizer launch --help > $ mesos-containerizer mount --help > $ mesos-containerizer network-cni-setup --help > > > Thanks, > > Benjamin Bannier > >
