----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52069/ -----------------------------------------------------------
(Updated 九月 19, 2016, 11:14 p.m.) Review request for mesos, Abhishek Dasgupta and Vinod Kone. Summary (updated) ----------------- Moved `CHECK_NE` close to the `if (task.isSome())`. Repository: mesos Description (updated) ------- We would vote `CHECK_NE` close to the `if (task.isSome())` loop because the `CHECK_NE` just above it makes it clear that taskGroup is some in the else block. Diffs (updated) ----- src/cli/execute.cpp f1806723b25c72839475769e85fd7cbe0126d67d Diff: https://reviews.apache.org/r/52069/diff/ Testing ------- make make check Thanks, Guangya Liu
