-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52069/#review149576
-----------------------------------------------------------


Ship it!




Ship It!

- Vinod Kone


On Sept. 19, 2016, 11:14 p.m., Guangya Liu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52069/
> -----------------------------------------------------------
> 
> (Updated Sept. 19, 2016, 11:14 p.m.)
> 
> 
> Review request for mesos, Abhishek Dasgupta and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> We would vote `CHECK_NE` close to the `if (task.isSome())` loop
> because the `CHECK_NE` just above it makes it clear that taskGroup
> is some in the else block.
> 
> 
> Diffs
> -----
> 
>   src/cli/execute.cpp f1806723b25c72839475769e85fd7cbe0126d67d 
> 
> Diff: https://reviews.apache.org/r/52069/diff/
> 
> 
> Testing
> -------
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Reply via email to