----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52056/ -----------------------------------------------------------
Review request for mesos, Jie Yu and Vinod Kone. Repository: mesos Description ------- Currently the callers of `destroy` cannot determine if the call succeeds or fails (without a secondary call to `wait()`). This also allows the caller to distinguish between a failure and waiting on an unknown container. This is important for the upcoming agent child container API, as the end-user would benefit from the distinction. Diffs ----- src/slave/containerizer/composing.hpp ef3c2ee22cf0ced35c64025c7f9f7ca75165d54d src/slave/containerizer/composing.cpp 5ff3e65facd5831e2637ae1cee3ea01b21d0f6b2 src/slave/containerizer/containerizer.hpp f13669d0dfc4ce3287cfe630cabd0470dc765b51 src/slave/containerizer/docker.hpp a378fa9772742b4934578efcec54aeeaf5791a83 src/slave/containerizer/docker.cpp 110a1eb41b1ff7cb94f3630a1843d9f01efbe09c src/slave/containerizer/mesos/containerizer.hpp 078ef4f4e7bf5e1522804a720c51cfa5518d8efd src/slave/containerizer/mesos/containerizer.cpp dc18e4e3b0eca3f116f1e240217bbebf64a75e3a src/tests/containerizer.hpp f1fd57945c09fb80b7790f9124843a5d4ea785ee src/tests/containerizer.cpp bda3e6f84f77a95f0eb9ff3aabdc9513f0f18b3f src/tests/containerizer/composing_containerizer_tests.cpp 51aab33cd190b53328339e39fd12853714882454 src/tests/containerizer/docker_containerizer_tests.cpp 28cd3fa66886dbdbae3fdeca77707147faafcb7a src/tests/containerizer/mesos_containerizer_tests.cpp 96e24500a12825161553eb050da389088b122695 Diff: https://reviews.apache.org/r/52056/diff/ Testing ------- Added tests. make check Thanks, Benjamin Mahler
