> On 八月 25, 2016, 7:17 p.m., Kevin Klues wrote:
> > src/slave/containerizer/mesos/isolators/gpu/allocator.cpp, lines 146-149
> > <https://reviews.apache.org/r/50947/diff/4/?file=1472874#file1472874line146>
> >
> >     This comment is confusing. I'd probably just leave it as it was, but 
> > say that this is only required for the mesos containerizer, i.e.:
> >     
> >     `` Don't allow the `--nvidia_gpu_devices` flag without the GPU isolator 
> > when using the mesos containerizer. For the docker containerizers, this is 
> > not required.```

Fixed comments as you suggested.


- Yubo


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50947/#review146831
-----------------------------------------------------------


On 八月 15, 2016, 7:29 a.m., Yubo Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50947/
> -----------------------------------------------------------
> 
> (Updated 八月 15, 2016, 7:29 a.m.)
> 
> 
> Review request for mesos, Benjamin Mahler, Guangya Liu, Kevin Klues, and 
> Rajat Phull.
> 
> 
> Bugs: MESOS-5975
>     https://issues.apache.org/jira/browse/MESOS-5975
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Mesos containerizer uses isolator 'gpu/nvidia' for GPU isolation while
> docker and external containerizers do not need it anymore. This removed
> the 'gpu/nvidia' isolator check for docker and external containerizers.
> 
> 
> Diffs
> -----
> 
>   src/slave/containerizer/mesos/isolators/gpu/allocator.cpp 
> c1a87e9e5c07529bc1d077f68477108a40506806 
> 
> Diff: https://reviews.apache.org/r/50947/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Yubo Li
> 
>

Reply via email to