----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52118/#review149876 -----------------------------------------------------------
src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 326 - 327) <https://reviews.apache.org/r/52118/#comment217622> Looks like the link does not have details about opaque whiteout files. Can you also include a link to the docker source code? Maybe a link to the OCI spec which has specification for that? BTW, once we start to support OCI image spec, we need to factor out the whiteout file handling to a common location so both of the image type can benefit from it. src/slave/containerizer/mesos/provisioner/provisioner.cpp (lines 368 - 369) <https://reviews.apache.org/r/52118/#comment217628> Can you adjust the indentation: ``` whiteout.push_back(path::join( path.dirname(), path.basename().substr(strlen(spec::WHITEOUT_PREFIX)))); ``` src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 376) <https://reviews.apache.org/r/52118/#comment217625> Failed to remove whiteout file src/slave/containerizer/mesos/provisioner/provisioner.cpp (line 402) <https://reviews.apache.org/r/52118/#comment217629> Please add a NOTE that this is because the file might be removed due to whiteout files higher up in the directory hierarchy. - Jie Yu On Sept. 21, 2016, 3:26 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52118/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 3:26 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-6215 > https://issues.apache.org/jira/browse/MESOS-6215 > > > Repository: mesos > > > Description > ------- > > Added support for opaque whiteout file `.wh..wh..opq`. > > > Diffs > ----- > > include/mesos/docker/spec.hpp 92367cf942c7ee4c23b1265b659f01d427212f62 > src/slave/containerizer/mesos/provisioner/provisioner.cpp > f37c45ccfa572876dfbba6a0797c223896db5a7f > > Diff: https://reviews.apache.org/r/52118/diff/ > > > Testing > ------- > > make check on Ubuntu 14.04. > > > Thanks, > > Qian Zhang > >
