> On Sept. 23, 2016, 4:43 p.m., haosdent huang wrote: > > 3rdparty/stout/tests/os_tests.cpp, lines 697-699 > > <https://reviews.apache.org/r/52048/diff/2/?file=1507948#file1507948line697> > > > > How about `EXPECT_EQ(tokens.get(), expected_gids);` here? > > Mao Geng wrote: > Not sure if EXPECT_EQ can compare two vectors directly? > I saw > https://github.com/google/googletest/blob/master/googletest/docs/Primer.md > has an example: > ``` > for (int i = 0; i < x.size(); ++i) { > EXPECT_EQ(x[i], y[i]) << "Vectors x and y differ at index " << i; > } > ``` > > Mao Geng wrote: > Just tested EXPECT_EQ can compare two vectors perfectly. Thanks @haosdent > for pointing it out. I am updating the diff
Done - Mao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review150202 ----------------------------------------------------------- On Sept. 23, 2016, 11:59 p.m., Mao Geng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52048/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 11:59 p.m.) > > > Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5909 > https://issues.apache.org/jira/browse/MESOS-5909 > > > Repository: mesos > > > Description > ------- > > Fixed OsTest.User test failure due to gids ordering. > > > Diffs > ----- > > 3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 > > Diff: https://reviews.apache.org/r/52048/diff/ > > > Testing > ------- > > Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS. > > > Thanks, > > Mao Geng > >
