> On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 691 > > <https://reviews.apache.org/r/52048/diff/1/?file=1502864#file1502864line691> > > > > Let's call this variable `expected_gids`.
Done > On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 695 > > <https://reviews.apache.org/r/52048/diff/1/?file=1502864#file1502864line695> > > > > We don't actually include `std::sort` in the headers, so this shouldn't > > be able to compile... > > > > Either way, you should fully qualify this function. > > Mao Geng wrote: > Agree it should be fully qualified. However, last diff didn't fail to > compile - I suspect a header file with "using namespace std" is included by > accident. Done > On Sept. 22, 2016, 1:47 a.m., Joseph Wu wrote: > > 3rdparty/stout/tests/os_tests.cpp, line 700 > > <https://reviews.apache.org/r/52048/diff/1/?file=1502864#file1502864line700> > > > > No need to clear this vector, especially since it won't be re-used. Done - Mao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52048/#review149936 ----------------------------------------------------------- On Sept. 23, 2016, 11:59 p.m., Mao Geng wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52048/ > ----------------------------------------------------------- > > (Updated Sept. 23, 2016, 11:59 p.m.) > > > Review request for mesos, Gilbert Song, Kapil Arya, and Joseph Wu. > > > Bugs: MESOS-5909 > https://issues.apache.org/jira/browse/MESOS-5909 > > > Repository: mesos > > > Description > ------- > > Fixed OsTest.User test failure due to gids ordering. > > > Diffs > ----- > > 3rdparty/stout/tests/os_tests.cpp c2900b8bf25b06a498c32c81bd2f8c852eb682f5 > > Diff: https://reviews.apache.org/r/52048/diff/ > > > Testing > ------- > > Just changed the OsTest.User test. `make check` passed on Ubuntu 12.04.5 LTS. > > > Thanks, > > Mao Geng > >
