> On Sept. 27, 2016, 12:31 a.m., Joseph Wu wrote: > > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp, lines > > 159-164 > > <https://reviews.apache.org/r/52285/diff/1/?file=1510517#file1510517line159> > > > > The comment on `container_path` in the `Volume` proto says: > > > If the path is an absolute path, that path must already exist. > > > > Perhaps we should amend this comment? (Because `os::mkdir` doesn't > > error if the target directory already exists.) > > > > I see that the `!has_rootfs()` code path checks for existence.
Yeah, we should update the `Volume` protobuf documentation. This restriction only applies if the container uses host filesystem. - Jie ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52285/#review150491 ----------------------------------------------------------- On Sept. 26, 2016, 11:16 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52285/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2016, 11:16 p.m.) > > > Review request for mesos, Gilbert Song and Joseph Wu. > > > Bugs: MESOS-6258 > https://issues.apache.org/jira/browse/MESOS-6258 > > > Repository: mesos > > > Description > ------- > > Added 'volume/sandbox_path' isolator. > > > Diffs > ----- > > src/CMakeLists.txt 981b36e55785b9de00a79693d5b25fe66fccb710 > src/Makefile.am 410b5f2e5bc50a5aa7856645c8cf4a3e43505a84 > src/slave/containerizer/mesos/isolators/volume/sandbox_path.hpp > PRE-CREATION > src/slave/containerizer/mesos/isolators/volume/sandbox_path.cpp > PRE-CREATION > > Diff: https://reviews.apache.org/r/52285/diff/ > > > Testing > ------- > > To be added. Wait for the nested container support. > > > Thanks, > > Jie Yu > >
