----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151984 -----------------------------------------------------------
Fix it, then Ship it! Looks very good guys - thanks Kevin for reviewing and Benjamin for actually making it happen - we all will love this stuff! :) I specifically like the idea of not finishing right here but keeping an eye on the results / demands and doing further iterations. support/mesos-gtest-runner.py (line 4) <https://reviews.apache.org/r/51715/#comment220659> Can we please add a license header - AFAIK the Apache Foundation is rather clear on this; every single source file needs to contain such header. Maybe it made sense to add a ticket which fixes that lack of license headers in the other support-scripts? - Till Toenshoff On Oct. 1, 2016, 7:06 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51715/ > ----------------------------------------------------------- > > (Updated Oct. 1, 2016, 7:06 p.m.) > > > Review request for mesos, Kevin Klues and Till Toenshoff. > > > Bugs: MESOS-6140 > https://issues.apache.org/jira/browse/MESOS-6140 > > > Repository: mesos > > > Description > ------- > > This adds `b814987b28cfb65a7c9635c83399545e423e690a` of > https://github.com/bbannier/gtest-shrdr. > > > Diffs > ----- > > support/mesos-gtest-runner.py PRE-CREATION > > Diff: https://reviews.apache.org/r/51715/diff/ > > > Testing > ------- > > Tested with e.g., `stout-tests` > > $ ./support/mesos-gtest-runner.py build/3rdparty/stout/stout-tests > ............ > [PASS] > > > Thanks, > > Benjamin Bannier > >
