> On Oct. 10, 2016, 5:22 p.m., Till Toenshoff wrote: > > Looks very good guys - thanks Kevin for reviewing and Benjamin for actually > > making it happen - we all will love this stuff! :) > > > > I specifically like the idea of not finishing right here but keeping an eye > > on the results / demands and doing further iterations.
I added a `TODO` to that effect. > On Oct. 10, 2016, 5:22 p.m., Till Toenshoff wrote: > > support/mesos-gtest-runner.py, line 4 > > <https://reviews.apache.org/r/51715/diff/5/?file=1517713#file1517713line4> > > > > Can we please add a license header - AFAIK the Apache Foundation is > > rather clear on this; every single source file needs to contain such header. > > > > Maybe it made sense to add a ticket which fixes that lack of license > > headers in the other support-scripts? Of course! I added the license header and filed https://issues.apache.org/jira/browse/MESOS-6359. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51715/#review151984 ----------------------------------------------------------- On Oct. 11, 2016, 10:18 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51715/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 10:18 a.m.) > > > Review request for mesos, Kevin Klues and Till Toenshoff. > > > Bugs: MESOS-6140 > https://issues.apache.org/jira/browse/MESOS-6140 > > > Repository: mesos > > > Description > ------- > > This adds `b814987b28cfb65a7c9635c83399545e423e690a` of > https://github.com/bbannier/gtest-shrdr. > > > Diffs > ----- > > support/mesos-gtest-runner.py PRE-CREATION > > Diff: https://reviews.apache.org/r/51715/diff/ > > > Testing > ------- > > Tested with e.g., `stout-tests` > > $ ./support/mesos-gtest-runner.py build/3rdparty/stout/stout-tests > ............ > [PASS] > > > Thanks, > > Benjamin Bannier > >
