----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review151392 -----------------------------------------------------------
Ditto comments for the versioned protobuf. include/mesos/master/master.proto (line 475) <https://reviews.apache.org/r/51774/#comment219782> s/disconnect/disconnection include/mesos/master/master.proto (line 476) <https://reviews.apache.org/r/51774/#comment219783> This can fit on the previous line itself? include/mesos/master/master.proto (line 481) <https://reviews.apache.org/r/51774/#comment219755> 1. Can we also add some examples on when an agent can be removed similar to what we did for `AGENT_ADDED`? 2. Can we also add a `NOTE` that it's possible that an agent might become active once it has been removed i.e., if the master has gc'ed its list of known "dead" agents. See MESOS-5965 for context. include/mesos/master/master.proto (line 483) <https://reviews.apache.org/r/51774/#comment219709> Let's change this to be just `AgentID` since this is all the subscribers should care about per se i.e., they would already have the agent details as part of the cluster snapshot or the `AGENT_ADDED` event. - Anand Mazumdar On Oct. 4, 2016, 2:45 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51774/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2016, 2:45 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-6102 > https://issues.apache.org/jira/browse/MESOS-6102 > > > Repository: mesos > > > Description > ------- > > Add `AGENT_ADDED` and `AGENT_REMOVED` master events. > > > Diffs > ----- > > include/mesos/master/master.proto 1ea79fd7ecd9c2b7e94718fc8c7779d1051583db > include/mesos/v1/master/master.proto > 58dc65006658f47bb752ee1c0c1520ee3cc03bd7 > > Diff: https://reviews.apache.org/r/51774/diff/ > > > Testing > ------- > > New unit test. > > > Thanks, > > Zhitao Li > >
