----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review151726 -----------------------------------------------------------
Fix it, then Ship it! I would fix these while committing. Also, would update the description to be more informative. include/mesos/v1/master/master.proto (line 486) <https://reviews.apache.org/r/51774/#comment220199> s/NOTE that/NOTE: It's - Anand Mazumdar On Oct. 6, 2016, 8:17 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51774/ > ----------------------------------------------------------- > > (Updated Oct. 6, 2016, 8:17 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-6102 > https://issues.apache.org/jira/browse/MESOS-6102 > > > Repository: mesos > > > Description > ------- > > Added `AGENT_ADDED` and `AGENT_REMOVED` master events. > > > Diffs > ----- > > include/mesos/master/master.proto 1ea79fd7ecd9c2b7e94718fc8c7779d1051583db > include/mesos/v1/master/master.proto > 58dc65006658f47bb752ee1c0c1520ee3cc03bd7 > > Diff: https://reviews.apache.org/r/51774/diff/ > > > Testing > ------- > > New unit test. > > > Thanks, > > Zhitao Li > >
