----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51774/#review151691 -----------------------------------------------------------
include/mesos/master/master.proto (line 482) <https://reviews.apache.org/r/51774/#comment220139> s/after/within s/since a master re-election/upon a master failover include/mesos/master/master.proto (lines 483 - 484) <https://reviews.apache.org/r/51774/#comment220141> hmm, this is not true anymore after the recent agent partition aware changes. We move the agent to a list of unreachable agents but do not invoke `removeSlave()` since it can come back at some point in the future. Hence, you won't get the `_REMOVED` event. We might want to add an `_UNCREACHABLE` event if a subscriber is interested in them sometime later. Can we rephrase the comment after "or," to say that this can also happen when the agent is scheduled for maintenance instead? include/mesos/master/master.proto (line 485) <https://reviews.apache.org/r/51774/#comment220143> s/Note/NOTE: Also, new line before this line. - Anand Mazumdar On Oct. 5, 2016, 11:45 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51774/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 11:45 p.m.) > > > Review request for mesos, Anand Mazumdar, Xiaojian Huang, haosdent huang, and > Vinod Kone. > > > Bugs: MESOS-6102 > https://issues.apache.org/jira/browse/MESOS-6102 > > > Repository: mesos > > > Description > ------- > > Add `AGENT_ADDED` and `AGENT_REMOVED` master events. > > > Diffs > ----- > > include/mesos/master/master.proto 1ea79fd7ecd9c2b7e94718fc8c7779d1051583db > include/mesos/v1/master/master.proto > 58dc65006658f47bb752ee1c0c1520ee3cc03bd7 > > Diff: https://reviews.apache.org/r/51774/diff/ > > > Testing > ------- > > New unit test. > > > Thanks, > > Zhitao Li > >
