> On Sept. 23, 2016, 6:42 p.m., Joseph Wu wrote: > > It's a bit odd that this function signature has a double. We should > > investigate why and decided whether or not we should change the interface > > to `uint64_t`.
I double checked where we use the multiplication/division operators for `Bytes`. As it turns out, they are only used in two tests. And only one test actually multiplies/divides by a decimal value. https://reviews.apache.org/r/52652/ https://reviews.apache.org/r/52653/ - Joseph ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52192/#review150283 ----------------------------------------------------------- On Sept. 28, 2016, 9:33 p.m., Daniel Pravat wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52192/ > ----------------------------------------------------------- > > (Updated Sept. 28, 2016, 9:33 p.m.) > > > Review request for mesos, Alex Clemmer and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Fixed VC warnings in bytes.hpp. > > > Diffs > ----- > > 3rdparty/stout/include/stout/bytes.hpp > 9debe2f5579b9b2d67933ecc2bfcc40c2730f7f1 > > Diff: https://reviews.apache.org/r/52192/diff/ > > > Testing > ------- > > > Thanks, > > Daniel Pravat > >
