----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/#review151906 -----------------------------------------------------------
Patch looks great! Reviews applied: [52642] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh - Mesos ReviewBot On Oct. 7, 2016, 6 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52642/ > ----------------------------------------------------------- > > (Updated Oct. 7, 2016, 6 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Bugs: MESOS-6142 > https://issues.apache.org/jira/browse/MESOS-6142 > > > Repository: mesos > > > Description > ------- > > Don't allow a reservation if the framework role doesn't match the role > of all the resources. > > > Diffs > ----- > > src/master/http.cpp bb9c87327dfe2161a6f1fd4cded72aa9a5ffaf66 > src/master/master.cpp c7e74df71aa31edb490f4f3bd95f2d5aa94b4324 > src/master/validation.hpp 035f721c610ae566c89a1cf0e65ff0df11679f15 > src/master/validation.cpp e5da3c9bf0a1042b42522f1ab74ce798fbb1738d > src/tests/master_validation_tests.cpp > 99e350e0587e73e9ee25ef20dd369cd146bd446a > src/tests/reservation_tests.cpp 6c28ab4557f342134efce0ad7cb174a5adb4dc10 > > Diff: https://reviews.apache.org/r/52642/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gastón Kleiman > >
