> On Nov. 3, 2016, 10:39 p.m., Benjamin Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 207-218 > > <https://reviews.apache.org/r/52642/diff/2/?file=1544212#file1544212line207> > > > > Hm.. it's too bad this test wasn't doing what its comment said, > > otherwise we'd have found this earlier :) > > > > Just a note, I find the following a bit clearer for the validation > > assertions: > > > > ``` > > Option<Error> error = operation::validate(...); > > > > EXPECT_SOME(error); > > ``` > > > > But since all of the tests don't use this pattern right now, it would > > be better to do a sweep. > > Gastón Kleiman wrote: > I agree and will post a patch with the sweeping change.
Here's the patch with the sweeping change: https://reviews.apache.org/r/53529/ - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52642/#review154824 ----------------------------------------------------------- On Nov. 7, 2016, 11:02 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52642/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2016, 11:02 a.m.) > > > Review request for mesos, Alexander Rukletsov and Michael Park. > > > Bugs: MESOS-6142 > https://issues.apache.org/jira/browse/MESOS-6142 > > > Repository: mesos > > > Description > ------- > > Don't allow a reservation if the framework role doesn't match the role > of all the resources. > > > Diffs > ----- > > src/master/http.cpp 2f275f6c78b92e13bd7d38043b581b5a3555ee40 > src/master/master.cpp 15ad5a647fc71d36ffd149893b3b9448a7d99323 > src/master/validation.hpp ed878ef64c6bc49cfa1738f97c7af047f06ffee7 > src/master/validation.cpp 658f0dd1085c83cd82f8d2b0e2c4ec0ba785bb92 > src/tests/master_validation_tests.cpp > 8697bb2dc05c54553066ace58553f0e40dfcb5f5 > > Diff: https://reviews.apache.org/r/52642/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Gastón Kleiman > >
