> On Oct. 6, 2016, 3:40 p.m., Alexander Rukletsov wrote: > > Please add support for > > * docker executor > > * pod (default) executor > > Gastón Kleiman wrote: > The default executor has no use for this env variable yet. Should I add > it as an unused attribute in the `DefaultExecutor` class?
We will need it for MESOS-6119, hence it's fine to introduce an yet unused variable. - Alexander ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/#review151657 ----------------------------------------------------------- On Oct. 10, 2016, 12:35 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52556/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 12:35 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Jie Yu, and > Jiang Yan Xu. > > > Bugs: MESOS-6288 > https://issues.apache.org/jira/browse/MESOS-6288 > > > Repository: mesos > > > Description > ------- > > This environment variable points to the directory containing the > binaries used by the Mesos Agent. It will eventually replace the > `--launcher-dir` executor flag. > > > Diffs > ----- > > docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 > src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 > src/slave/slave.cpp d30001bc0d1798311ba3966f67aadc6be2c92306 > > Diff: https://reviews.apache.org/r/52556/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Gastón Kleiman > >
