> On Oct. 11, 2016, 4:22 p.m., Jie Yu wrote: > > Can you explain why you want to replace `launcher_dir`? Looking at the > > attached ticket, seems like this is irrelevant?
I just updated the patch to also add support for the new env variable to the "default executor". I'm adding this new env variable, because `launcher_dir` is passed as a flag, and the recently introduced "default executor" doesn't use flags at all. The command executor uses a mix of flags and env variables. I would like to make it more consistent and make it use only env variables. @xujyan/@jieyu if I create a new patch to make the command executor use only env variables, would you be willing to shepherd it? - Gastón ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/#review152145 ----------------------------------------------------------- On Oct. 11, 2016, 6:52 p.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52556/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 6:52 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Jie Yu, and > Jiang Yan Xu. > > > Bugs: MESOS-6288 > https://issues.apache.org/jira/browse/MESOS-6288 > > > Repository: mesos > > > Description > ------- > > This environment variable points to the directory containing the > binaries used by the Mesos Agent. It will eventually replace the > `--launcher-dir` executor flag. > > > Diffs > ----- > > docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 > src/launcher/default_executor.cpp 2454bd7df608254af72af01460782f5ab78a19c1 > src/launcher/executor.cpp 3e95d6029bea0ce6e0dfb39c24b795fe98d90d13 > src/slave/slave.cpp 119fb36c27b25739f2a86a55d48e964ca4a84ff7 > > Diff: https://reviews.apache.org/r/52556/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Gastón Kleiman > >
