> On Oct. 10, 2016, 8:32 a.m., Jiang Yan Xu wrote: > > src/launcher/executor.cpp, lines 903-910 > > <https://reviews.apache.org/r/52556/diff/2/?file=1525587#file1525587line903> > > > > You didn't start this but I wonder why we can't consistently use the > > flags, which can be provided through environment variables, i.e., use > > `flags.load("MESOS_", &argc, &argv);` above. > > > > That question aside, I don't think we need to be concerned about > > backwards-compatibility here: this is the command executor bundled with the > > agent so they are upgraded together. i.e., we are sure that the agent is > > setting the new variable. > > Gastón Kleiman wrote: > Wouldn't then the tasks started between the moment in which the binary is > overwritten and the moment in which the Mesos Agent is restarted fail?
OK I guess it'll be helpful in this regard. My main point is that this is not a deprecation cycle concern. Generally it's advisable to restart the agent right after upgrading it but even though it's done this way with most Mesos toolings I have seen, I've also seen tasks failing when launched mid-upgrade with libmesos and executable mismatch. Therefore, fine with me to do this to aid N -> N+1 upgrade. If we do this, the cleaniest approach may be flag aliases. - Jiang Yan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52556/#review151918 ----------------------------------------------------------- On Oct. 10, 2016, 5:35 a.m., Gastón Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52556/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 5:35 a.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Jie Yu, and > Jiang Yan Xu. > > > Bugs: MESOS-6288 > https://issues.apache.org/jira/browse/MESOS-6288 > > > Repository: mesos > > > Description > ------- > > This environment variable points to the directory containing the > binaries used by the Mesos Agent. It will eventually replace the > `--launcher-dir` executor flag. > > > Diffs > ----- > > docs/executor-http-api.md 50b4cb4efff48bcc56330b81bd7c4c217b8a22b5 > src/launcher/executor.cpp 8a1051b886a0c95d19ff370e5c77d9c4033c8b61 > src/slave/slave.cpp d30001bc0d1798311ba3966f67aadc6be2c92306 > > Diff: https://reviews.apache.org/r/52556/diff/ > > > Testing > ------- > > `make check` > > > Thanks, > > Gastón Kleiman > >
