----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152008 -----------------------------------------------------------
configure.ac (line 460) <https://reviews.apache.org/r/52645/#comment220690> GCC 4.9 is in devtoolset-3 for RHEL 6, so I think this is fine. IMHO it is still worth giving the mailing list a heads-up though. src/Makefile.am (line 117) <https://reviews.apache.org/r/52645/#comment220688> Since you are now putting the compiler flags in the correct variables, you can remove then from ``MESOS_CPPFLAGS`` (which should only contain preprocessor options). - James Peach On Oct. 10, 2016, 3:42 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52645/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 3:42 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Use a default set of flags to provide additional security and hardening to > Mesos. Additionally, check and catch more warnings/errors. > > > Diffs > ----- > > configure.ac 034bb91 > src/Makefile.am fd01e1d > > Diff: https://reviews.apache.org/r/52645/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
