----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52645/#review152042 -----------------------------------------------------------
I will leave comments about requiring GCC 4.9 to people who are more qualified to comment on it, but if we are enforcing this, then we do need to make it a requirement in the CMake build as well. - Alex Clemmer On Oct. 10, 2016, 6:16 p.m., Aaron Wood wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52645/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2016, 6:16 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-6229 > https://issues.apache.org/jira/browse/MESOS-6229 > > > Repository: mesos > > > Description > ------- > > Use a default set of flags to provide additional security and hardening to > Mesos. Additionally, check and catch more warnings/errors. > > > Diffs > ----- > > configure.ac 034bb91 > src/Makefile.am fd01e1d > > Diff: https://reviews.apache.org/r/52645/diff/ > > > Testing > ------- > > Compared the benchmarks with and without the flags being used. Also did a > comparsion with the flags being used with and without optimizations and > without the flags being used with and without optimizations. Overall the > performance hit was very small with a 3-8% overhead (optimizations brings > this down slightly). Most benchmarks were about 5% (or less) slower. > > > Thanks, > > Aaron Wood > >
