----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52695/ -----------------------------------------------------------
(Updated Nov. 1, 2016, 10:22 p.m.) Review request for mesos, James Peach, Michael Park, and Neil Conway. Changes ------- Provide compiler flag support macro. This works without the macro here since it's in the base Mesos `m4` directory but it's better to treat these as separate, contained "third party" libraries. Bugs: MESOS-6229 https://issues.apache.org/jira/browse/MESOS-6229 Repository: mesos Description ------- Use a default set of flags to provide additional security and hardening to libprocess. Additionally, check and catch more warnings/errors. Diffs (updated) ----- 3rdparty/libprocess/Makefile.am 7131989 3rdparty/libprocess/configure.ac 1644035 3rdparty/libprocess/m4/ax_check_compile_flag.m4 PRE-CREATION Diff: https://reviews.apache.org/r/52695/diff/ Testing ------- Compared the benchmarks with and without the flags being used. Also did a comparsion with the flags being used with and without optimizations and without the flags being used with and without optimizations. Overall the performance hit was very small with a 3-8% overhead (optimizations brings this down slightly). Most benchmarks were about 5% (or less) slower. Thanks, Aaron Wood