----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52310/#review152086 -----------------------------------------------------------
Fix it, then Ship it! Once this last comment is tweaked, this commit should be good-to-go. I'll commit it with the rest of the chain, when the whole chain is ready. src/slave/container_loggers/logrotate.cpp (lines 246 - 247) <https://reviews.apache.org/r/52310/#comment220812> Suggestion: ``` If the `--user` flag is set, change the UID of this process to that user. ``` Note: This binary is built as the "mesos-logrotate-logger", rather than the "mesos-logger-logrotate" :) - Joseph Wu On Oct. 5, 2016, 8:07 p.m., Sivaram Kannan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52310/ > ----------------------------------------------------------- > > (Updated Oct. 5, 2016, 8:07 p.m.) > > > Review request for mesos and Joseph Wu. > > > Bugs: MESOS-5856 > https://issues.apache.org/jira/browse/MESOS-5856 > > > Repository: mesos > > > Description > ------- > > Switch the uid of the binary if a user is passed from the lib_logrotate. > > > Diffs > ----- > > src/slave/container_loggers/logrotate.cpp > 431bc3cbb54e94359078e4dae0b32ad301393640 > > Diff: https://reviews.apache.org/r/52310/diff/ > > > Testing > ------- > > 1. Run the mesos-logrotate-logger with un-priviledged user and verify whether > the logs are getting rotated. > 2. Run the mesos-logrotate-logger as root user and verify whether the logs > are getting rotated. > > > Thanks, > > Sivaram Kannan > >
