-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52715/#review152090
-----------------------------------------------------------




src/tests/mesos.hpp (line 446)
<https://reviews.apache.org/r/52715/#comment220822>

    It's a bit weird that we need to pass on v0 arguments to create a v1 
executor info. Can you pass in `v1::ExecutorInfo::Type` instead?


- Anand Mazumdar


On Oct. 11, 2016, 1:15 a.m., Gilbert Song wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52715/
> -----------------------------------------------------------
> 
> (Updated Oct. 11, 2016, 1:15 a.m.)
> 
> 
> Review request for mesos, Anand Mazumdar, Jie Yu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Added a test helper 'createV1ExecutorInfo()'.
> 
> 
> Diffs
> -----
> 
>   src/tests/mesos.hpp 5e15f5164cddebd60bb6d9856ae63ad357643cb2 
> 
> Diff: https://reviews.apache.org/r/52715/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Reply via email to