----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52730/#review152195 -----------------------------------------------------------
Just a quick point here, there is a semantic mismatch between Windows and (all?) modern POSIX implementations in the C standard environment APIs. Much of this is captured in [1]; if I'm remembering right, I ended up concluding that it was likely that we were going to have to retire `os::environ` and `os::raw::environ` to replace it with a platform-independent environment API. Specifically this would probably entail replacing every function that expects a POSIX environment, with a corresponding function that takes the platform-independent environment object. It looks like this review is most of the way there already... if you think this makes sense as a goal for the work you're doing here, I'm happy to add some suggestions about what would be helpful on the Windows side to resolve our issues. [1] https://issues.apache.org/jira/browse/MESOS-5880 - Alex Clemmer On Oct. 11, 2016, 5:38 a.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52730/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2016, 5:38 a.m.) > > > Review request for mesos, Gilbert Song and Kevin Klues. > > > Bugs: MESOS-6323 > https://issues.apache.org/jira/browse/MESOS-6323 > > > Repository: mesos > > > Description > ------- > > Added an abstraction for Envp pointer expected by exec routines. > > > Diffs > ----- > > 3rdparty/stout/include/stout/os/raw/environment.hpp > 80cc45b24cfe6f6429d4d0ed4acdafba51c590eb > > Diff: https://reviews.apache.org/r/52730/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
