----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review152516 -----------------------------------------------------------
src/docker/docker.hpp (lines 98 - 101) <https://reviews.apache.org/r/50125/#comment221530> We generally do not put `+` at the begining of the code, you can update as following: ``` if (deviceInfo.size() != 3) { return Error("Parse device information error for '" + devices + "', 'PathInHost:PathInContainer:Permission' expected"); } ``` Also you should quota `PathInHost:PathInContainer:Permission` as above to hightlight it. src/docker/executor.hpp (line 81) <https://reviews.apache.org/r/50125/#comment221531> s/docker run/`docker run` src/slave/containerizer/docker.cpp (line 250) <https://reviews.apache.org/r/50125/#comment221544> kill this - Guangya Liu On 十月 13, 2016, 10:15 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > ----------------------------------------------------------- > > (Updated 十月 13, 2016, 10:15 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added a new flag '--devices' to mesos-docker-executor, and gave its > feature to control devices exposition, isolation, and access permission. > Also, passed GPUs assignment to mesos-docker-executor. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/executor.hpp a49ec1b4045116741af6af08578791fb0440ad8f > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/slave/containerizer/docker.cpp 1d27761fcb3f310cf954d45ed41f4c89ecbd5982 > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
