----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/50125/#review153395 -----------------------------------------------------------
src/docker/executor.cpp (line 790) <https://reviews.apache.org/r/50125/#comment222688> kill this src/slave/containerizer/docker.cpp (line 241) <https://reviews.apache.org/r/50125/#comment222698> s/Exposed/Expose src/slave/containerizer/docker.cpp (lines 344 - 346) <https://reviews.apache.org/r/50125/#comment222697> Can you please update the comments as well, now we have two `None()` fields here, both the `taskEnvironment` and `devices`. We do not set the optional `devices` here as this field is set when allocating gpu resources in `DockerContainerizerProcess::launchExecutorProcess`. So what about update the comments as: ``` // NOTE: We do not set the optional `taskEnvironment` and `devices` // here. The `taskEnvironment` field is currently used to propagate // environment variables from a hook, this hook is called after // `Container::create`. The `devices` field is currently used to // expose Nvidia devices to the docker container, this is set in // `DockerContainerizerProcess::launchExecutorProcess` which is also // after `Container::create`. ``` - Guangya Liu On 十月 20, 2016, 10:01 a.m., Yubo Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/50125/ > ----------------------------------------------------------- > > (Updated 十月 20, 2016, 10:01 a.m.) > > > Review request for mesos, Benjamin Mahler, Kevin Klues, and Rajat Phull. > > > Bugs: MESOS-5795 > https://issues.apache.org/jira/browse/MESOS-5795 > > > Repository: mesos > > > Description > ------- > > Added a new flag '--devices' to mesos-docker-executor, and gave its > feature to control devices exposition, isolation, and access permission. > Also, passed GPUs assignment to mesos-docker-executor. > > > Diffs > ----- > > src/docker/docker.hpp 9093371afc8ea792ba94f61c6875703e547ea6b0 > src/docker/executor.hpp 8385631fd170f97b28c4ca3596255ab0546774d6 > src/docker/executor.cpp ab3f0473fdc9105d1c425f0dbe7b81c566d541e8 > src/slave/containerizer/docker.cpp 8ec4c0a25335fb1b36cb2ab82577f6d3e2f7f008 > > Diff: https://reviews.apache.org/r/50125/diff/ > > > Testing > ------- > > make check > > > Thanks, > > Yubo Li > >
