This is an automatically generated e-mail. To reply, visit:

(Updated Oct. 14, 2016, 3:14 p.m.)

Review request for mesos, Michael Park and Neil Conway.


Targeted this RR at libprocess. There will be a separate one opened for stout.

Summary (updated)

Fix new sign comparison errors in libprocess produced by hardened flags

Bugs: MESOS-6239

Repository: mesos

Description (updated)

The hardening flags produced many new sign comparison errors in libprocess that 
need to be fixed for Mesos to compile/run.

Diffs (updated)

  3rdparty/libprocess/src/decoder.hpp c79296b 
  3rdparty/libprocess/src/encoder.hpp 005d1cc 
  3rdparty/libprocess/src/process.cpp 18a8e20 
  3rdparty/libprocess/src/tests/decoder_tests.cpp 4535614 
  3rdparty/libprocess/src/tests/encoder_tests.cpp 9e57375 
  3rdparty/libprocess/src/tests/http_tests.cpp 8d6c8c4 
  3rdparty/libprocess/src/tests/io_tests.cpp b85c79f 
  3rdparty/libprocess/src/tests/subprocess_tests.cpp c8350cf 

Diff: https://reviews.apache.org/r/52647/diff/


Made sure compilation, tests, and benchmarks worked with both gcc and clang. 
Ran `make && make check && make bench`.


Aaron Wood

Reply via email to