-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52786/#review152863
-----------------------------------------------------------


Fix it, then Ship it!





src/tests/containerizer/health_check_test_helper.cpp (line 66)
<https://reviews.apache.org/r/52786/#comment222030>

    Yhis method is so short, that I don't think we need this comment.
    
    But if you still think that it is needed, I'd remove the last part ('`which 
means that the authentication realm for libprocess-level HTTP endpoints was not 
set to the correct value for the master.`'), since it only applies to the Mesos 
Agent.


- Gastón Kleiman


On Oct. 12, 2016, 2:37 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52786/
> -----------------------------------------------------------
> 
> (Updated Oct. 12, 2016, 2:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Gastón Kleiman.
> 
> 
> Bugs: MESOS-6278
>     https://issues.apache.org/jira/browse/MESOS-6278
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This patch updates the test helper for the health check. Via starts a
> simple HTTP server which listens on given IP and port, it makes testing
> HTTP health check and TCP health check easier.
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am fd01e1dfbdb04d073484ff6b7cc94b8d769f8a8e 
>   src/tests/CMakeLists.txt f5d66dc63143455506d8660674fbd9eb227625ff 
>   src/tests/containerizer/health_check_test_helper.hpp PRE-CREATION 
>   src/tests/containerizer/health_check_test_helper.cpp PRE-CREATION 
>   src/tests/test_helper_main.cpp 129a5e427b72fb577e55c3756d071f72ced9ff14 
> 
> Diff: https://reviews.apache.org/r/52786/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Reply via email to